rubiline
/
Glitch-Shrike
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve `api/v1/markers#create` performance against simultaneous requests (#28718)

shrike
Matt Jankowski 2024-01-15 04:47:25 -05:00 committed by GitHub
parent cc3ff66246
commit e72676e83a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/api/v1/markers_controller.rb
View File

@ -19,7 +19,7 @@ class Api::V1::MarkersController < Api::BaseController
@markers = {} @markers = {}
resource_params.each_pair do |timeline, timeline_params| resource_params.each_pair do |timeline, timeline_params|
@markers[timeline] = current_user.markers.find_or_initialize_by(timeline: timeline) @markers[timeline] = current_user.markers.find_or_create_by(timeline: timeline)
@markers[timeline].update!(timeline_params) @markers[timeline].update!(timeline_params)
end end
end end

24
spec/controllers/api/v1/markers_controller_spec.rb → spec/requests/api/v1/markers_spec.rb
View File

@ -2,20 +2,18 @@
require 'rails_helper' require 'rails_helper'
RSpec.describe Api::V1::MarkersController do RSpec.describe 'API Markers' do
render_views let(:user) { Fabricate(:user) }
let(:scopes) { 'read:statuses write:statuses' }
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } }
let!(:user) { Fabricate(:user) } describe 'GET /api/v1/markers' do
let!(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read:statuses write:statuses') }
before { allow(controller).to receive(:doorkeeper_token) { token } }
describe 'GET #index' do
before do before do
Fabricate(:marker, timeline: 'home', last_read_id: 123, user: user) Fabricate(:marker, timeline: 'home', last_read_id: 123, user: user)
Fabricate(:marker, timeline: 'notifications', last_read_id: 456, user: user) Fabricate(:marker, timeline: 'notifications', last_read_id: 456, user: user)
get :index, params: { timeline: %w(home notifications) } get '/api/v1/markers', headers: headers, params: { timeline: %w(home notifications) }
end end
it 'returns markers', :aggregate_failures do it 'returns markers', :aggregate_failures do
@ -29,10 +27,10 @@ RSpec.describe Api::V1::MarkersController do
end end
end end
describe 'POST #create' do describe 'POST /api/v1/markers' do
context 'when no marker exists' do context 'when no marker exists' do
before do before do
post :create, params: { home: { last_read_id: '69420' } } post '/api/v1/markers', headers: headers, params: { home: { last_read_id: '69420' } }
end end
it 'creates a marker', :aggregate_failures do it 'creates a marker', :aggregate_failures do
@ -44,8 +42,8 @@ RSpec.describe Api::V1::MarkersController do
context 'when a marker exists' do context 'when a marker exists' do
before do before do
post :create, params: { home: { last_read_id: '69420' } } post '/api/v1/markers', headers: headers, params: { home: { last_read_id: '69420' } }
post :create, params: { home: { last_read_id: '70120' } } post '/api/v1/markers', headers: headers, params: { home: { last_read_id: '70120' } }
end end
it 'updates a marker', :aggregate_failures do it 'updates a marker', :aggregate_failures do