Add helper methods for domains allow and export blocks files (#28196)

shrike
Matt Jankowski 2023-12-04 03:52:21 -05:00 committed by GitHub
parent 3ec263bf15
commit d848d8d87c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions

View File

@ -24,7 +24,7 @@ RSpec.describe Admin::ExportDomainAllowsController do
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
expect(response.body).to eq(domain_allows_csv_file)
end
end
@ -40,7 +40,7 @@ RSpec.describe Admin::ExportDomainAllowsController do
# Domains should now be added
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
expect(response.body).to eq(domain_allows_csv_file)
end
it 'displays error on no file selected' do
@ -49,4 +49,10 @@ RSpec.describe Admin::ExportDomainAllowsController do
expect(flash[:error]).to eq(I18n.t('admin.export_domain_allows.no_file'))
end
end
private
def domain_allows_csv_file
File.read(File.join(file_fixture_path, 'domain_allows.csv'))
end
end

View File

@ -26,7 +26,13 @@ RSpec.describe Admin::ExportDomainBlocksController do
get :export, params: { format: :csv }
expect(response).to have_http_status(200)
expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_blocks.csv')))
expect(response.body).to eq(domain_blocks_csv_file)
end
private
def domain_blocks_csv_file
File.read(File.join(file_fixture_path, 'domain_blocks.csv'))
end
end