rubiline
/
Glitch-Shrike
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unnecessary “next” link when API returns fewer notification requests than requested (#31541)

shrike
Claire 2024-08-22 15:42:04 +02:00 committed by GitHub
parent abe292b0ec
commit 98237207e6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/controllers/api/v1/notifications/requests_controller.rb
View File

@ -75,13 +75,17 @@ class Api::V1::Notifications::RequestsController < Api::BaseController
end end
def next_path def next_path
api_v1_notifications_requests_url pagination_params(max_id: pagination_max_id) unless @requests.empty? api_v1_notifications_requests_url pagination_params(max_id: pagination_max_id) if records_continue?
end end
def prev_path def prev_path
api_v1_notifications_requests_url pagination_params(min_id: pagination_since_id) unless @requests.empty? api_v1_notifications_requests_url pagination_params(min_id: pagination_since_id) unless @requests.empty?
end end
def records_continue?
@requests.size == limit_param(DEFAULT_ACCOUNTS_LIMIT)
end
def pagination_max_id def pagination_max_id
@requests.last.id @requests.last.id
end end