rubiline
/
Glitch-Shrike
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ignore block result of `send` method and remove `rubocop:disable` in deepl spec (#27741)

shrike
Matt Jankowski 2023-11-08 09:43:17 -05:00 committed by GitHub
parent c73d5a6075
commit 4329616c53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
spec/lib/translation_service/deepl_spec.rb
View File

@ -8,12 +8,14 @@ RSpec.describe TranslationService::DeepL do
let(:plan) { 'advanced' } let(:plan) { 'advanced' }
before do before do
stub_request(:get, 'https://api.deepl.com/v2/languages?type=source').to_return( %w(api-free.deepl.com api.deepl.com).each do |host|
body: '[{"language":"EN","name":"English"},{"language":"UK","name":"Ukrainian"}]' stub_request(:get, "https://#{host}/v2/languages?type=source").to_return(
) body: '[{"language":"EN","name":"English"},{"language":"UK","name":"Ukrainian"}]'
stub_request(:get, 'https://api.deepl.com/v2/languages?type=target').to_return( )
body: '[{"language":"EN-GB","name":"English (British)"},{"language":"ZH","name":"Chinese"}]' stub_request(:get, "https://#{host}/v2/languages?type=target").to_return(
) body: '[{"language":"EN-GB","name":"English (British)"},{"language":"ZH","name":"Chinese"}]'
)
end
end end
describe '#translate' do describe '#translate' do
@ -73,28 +75,25 @@ RSpec.describe TranslationService::DeepL do
end end
end end
describe '#request' do describe 'the paid and free plan api hostnames' do
before do before do
stub_request(:any, //) service.languages
# rubocop:disable Lint/EmptyBlock
service.send(:request, :get, '/v2/languages') { |res| }
# rubocop:enable Lint/EmptyBlock
end end
it 'uses paid plan base URL' do context 'without a plan set' do
expect(a_request(:get, 'https://api.deepl.com/v2/languages')).to have_been_made.once it 'uses paid plan base URL and sends an API key' do
end expect(a_request(:get, 'https://api.deepl.com/v2/languages?type=source').with(headers: { Authorization: 'DeepL-Auth-Key my-api-key' })).to have_been_made.once
expect(a_request(:get, 'https://api.deepl.com/v2/languages?type=target').with(headers: { Authorization: 'DeepL-Auth-Key my-api-key' })).to have_been_made.once
context 'with free plan' do
let(:plan) { 'free' }
it 'uses free plan base URL' do
expect(a_request(:get, 'https://api-free.deepl.com/v2/languages')).to have_been_made.once
end end
end end
it 'sends API key' do context 'with the free plan' do
expect(a_request(:get, 'https://api.deepl.com/v2/languages').with(headers: { Authorization: 'DeepL-Auth-Key my-api-key' })).to have_been_made.once let(:plan) { 'free' }
it 'uses free plan base URL and sends an API key' do
expect(a_request(:get, 'https://api-free.deepl.com/v2/languages?type=source').with(headers: { Authorization: 'DeepL-Auth-Key my-api-key' })).to have_been_made.once
expect(a_request(:get, 'https://api-free.deepl.com/v2/languages?type=target').with(headers: { Authorization: 'DeepL-Auth-Key my-api-key' })).to have_been_made.once
end
end end
end end
end end